Closed sinsukehlab closed 1 year ago
I would leave the <!--step0-->
<!--endstep0-->
comment blocks in. End state would be to still hide the setup instructions after the course is started, but to put the course aims and LO in a details block.
Something like this
<!--<details id=0><summary>Course Aims</summary>-->
TBD-welcome-paragraph
- **Who is this for**: TBD-audience.
- **What you'll learn**: TBD-objective.
- **What you'll build**: TBD-result.
- **Prerequisites**: TBD-prerequisites.
- **How long**: This course is TBD-step-count steps long and takes less than TBD-duration to complete.
<!--</details>-->
<!--step0-->
The skills/action-update-step would also have to be updated to accommodate for blocks being removed from comments instead of added. (i.e. unhide the details tags).
Personally, I think it's good enough to just move the <!--step0-->
to below the course aims (i.e. just above ## How to start this course
).
What do you think of this commit? I don't think skills/action-update-step needs updating for this reason. I think it needs updating for the CI course though. Cf. skills/action-update-step#5
@sinsukehlab Looks ok. Summary title might be better as Course description
. My preference is not to put the course aims/description in a <details>
tag though (and also take out the summary title).
We need more opinions at this point and ideally we need some one from the GH Skills team to take a look at this and make a decision on if this is a direction they want to go in.
I've noted this feedback on an internal issue for the product folks to review.
I've merged something similar in https://github.com/skills/template-template/pull/28, thank you for the recommendation 🙏🏼
Why:
Some learners would like to browse Step 0.
Discussed in https://github.com/orgs/skills/discussions/24
What's being changed:
I changed the style of Step 0. I put Step 0 in a
<details>
tag instead of commenting it out.Check off the following: