skills / template-template

<<Not a course>> A template to make course templates. Search and replace "TBD".
MIT License
114 stars 36 forks source link

Add `get_current_step` jobs #24

Closed sinsukehlab closed 1 year ago

sinsukehlab commented 1 year ago

Why:

Some courses use get_current_step jobs. This feature helps the Actions workflows to function in numerical order.

What's being changed:

YAML files Add get_current_step jobs

Check off the following:

sinsukehlab commented 1 year ago

I will add some commits to stop using set-output commands. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

heiskr commented 1 year ago

Just ran across this working on something else:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-environment-variable

Might be less config to use GITHUB_ENV instead of state or output.

sinsukehlab commented 1 year ago

https://docs.github.com/en/actions/learn-github-actions/contexts#needs-context

heiskr commented 1 year ago

Thanks for getting a pull request for this :) I'd be happy to merge it, but content changes are out of my review scope, and it looks like the README.md changes are also in another pull request. If you able to reset those for this branch I can get this merged.

sinsukehlab commented 1 year ago

At first I reverted those commits, but on second thought I reset the reverting commits, checkouted to 4eecba3, committed the changes and force-pushed the local branch.

Reverting commits that were reset: 647462c f3b7487 82a7942