search

skills / test-with-actions

Create workflows that enable you to use Continuous Integration (CI) for your projects.
MIT License
221 stars 119 forks source link

[Bug] Step 5 switch not work #36

Open sovetski opened 1 year ago

sovetski commented 1 year ago

Summary

The file "/.github/workflows/4-add-branch-protections.yml" is not working, the step switching part is commented

image

How to reproduce

Just create a branch protection and nothing will happen to switching automatically to the next step

cuatrosr commented 1 year ago

This is how i solved it: Generate a PAT classic with repository public permissions, put it on GItHub Secrets and add it below checkout -> with: -> token: {{ PAT_SECRET }}. Also, uncomment all the lines of Update to step 5 and do a manual run of Step 4 workflow.

gjuliao commented 10 months ago

Faced the same issue as @sovetski. On my side that part appears uncommented but still nothing happens passed that stage after protecting the branch.

hectorsector commented 5 months ago

Thanks for the report, @sovetski.

Although the course looks different today than when originally reported, we're still seeing almost 40% learner drop off at this step so I'm inclined to believe it can stand some improvement.

hsnabszhdn commented 2 months ago

Happened to me as well; although confusing, I feel like an idiot after knowing what happened!

In step 4, it says enable branch protection rule on main (again on main). How could I expect the main branch to be updated automatically after this rule? No matter how many times I refreshed, of course it wouldn't change.

The instruction says: "...go to the ci branch..." (which I had missed)

image

And of course, after switching to the ci branch, there it was: step 5!