skills / test-with-actions

Create workflows that enable you to use Continuous Integration (CI) for your projects.
MIT License
221 stars 119 forks source link

[Bug] Package name in the npm call in 1-add-a-test-workflow.md #54

Closed rio197 closed 11 months ago

rio197 commented 11 months ago

Summary

Package name remark should be remark-cli instead

How to reproduce

  1. Go to 'https://github.com/skills/test-with-actions/blob/main/.github/steps/1-add-a-test-workflow.md'
  2. Click on '1-add-a-test-workflow.md'
  3. Scroll down to 'Activity: Add a test workflow'
  4. Go to "Step 7. Add the following step at the end of your workflow:"
  5. In the part that says "npx remark" it should be "npx remark-cli" instead.

Additional context

The student/learner will correct the "npx" to "npm" and the correct package name to invoke here is "remark-cli"

rio197 commented 11 months ago

Actually, "remark-cli" does not work either in my GitHub repo. I'm closing the bug for now and re-investigate.