skills / test-with-actions

Create workflows that enable you to use Continuous Integration (CI) for your projects.
MIT License
215 stars 117 forks source link

[Bug] add classic branch protection rule #70

Open fndejong93 opened 1 month ago

fndejong93 commented 1 month ago

Summary

The tutorial talks about "branch protection rules". In Github it is mentioned that this is the classic rule and that it is preferred to use branch ruleset.

How to reproduce

  1. Go to tutorial for steps 4
  2. follow the steps.
  3. Know you will see the button "add branch ruleset" but the tutorial wants you to click on "add classic branch protection rule"
  4. This was not very clear to me.

image

Additional context

Add any other context about the problem here.

nguyenalex836 commented 3 weeks ago

@fndejong93 Thank you for submitting this issue! I'll triage this for the team to review ✨