search

skills / test-with-actions

Create workflows that enable you to use Continuous Integration (CI) for your projects.
MIT License
216 stars 117 forks source link

[Bug] Step 4: Add branch protections - ruleset or classic rule? #71

Open TrangOul opened 3 weeks ago

TrangOul commented 3 weeks ago

Summary

There is a new branch protection setting ("ruleset") which this tutorial is not aware of.

How to reproduce

  1. Complete Steps 1-3, so the current one is Step 4: Add branch protections
  2. Follow the first step in the Activity: Add branch protections: Go to Branches settings. You can navigate to that page manually by selecting the right-most tab in the top of the repository called Settings and then clicking Branches.
  3. Notice that there are two settings available: Add branch ruleset and Add classic branch protection rule, which are not consistent with step 2: Click Add branch protection rule under "Branch protection rules".

image

Additional context

Please update the tutorial so it uses the new branch ruleset (better) or change it so it's clear to use a classic branch protection rule (worse, but acceptable as a hotfix).

nguyenalex836 commented 2 weeks ago

@TrangOul Thank you for raising this issue! ✨ I'll triage this for the team to review