skinkie / reference

Personal repository where I collect working examples to understand inner workings while building PyNeTExConv
GNU Affero General Public License v3.0
0 stars 1 forks source link

better import duckdb #10

Closed ue71603 closed 2 months ago

ue71603 commented 2 months ago

@skinkie I did completly not built on your last version. Perhaps we keep this as simpleimport.py

skinkie commented 2 months ago

I want to have the column mapping back.

ue71603 commented 2 months ago

there you are...

ue71603 commented 2 months ago

@skinkie better

skinkie commented 2 months ago

Not my preference. Create per file a dictionary, having the name, and target SQL type.

ue71603 commented 2 months ago

you are right. otherwise data types will be very bad.

skinkie commented 2 months ago

@ue71603 please evaluate if the current version in master is more than you wanted to do here. I think we can close this one.