search

skinniderlab / CLM

MIT License
0 stars 0 forks source link

Should use train0 and test0 here #141

Closed vineetbansal closed 3 months ago

vineetbansal commented 4 months ago

In write_structural_prior_CV, we should be using train0 and test0:

https://github.com/skinniderlab/CLM/blob/8cf35da0a08838b1b159227020de6ddf0f1c6ec0/snakemake/Snakefile#L352

vineetbansal commented 4 months ago

@skinnider - this makes sense - I guess we're saying that the whole process of augmentation is a modeling detail that doesn't participate in the evaluation.

I take it that a parallel change needs to be made in write_formula_prior as well.

skinnider commented 4 months ago

Yes, good catch!