skinniderlab / CLM

MIT License
0 stars 0 forks source link

Potential bug fixes with plots for nn_tc_ever_v_never/structural_prior_min_freq #216

Closed vineetbansal closed 1 week ago

vineetbansal commented 1 week ago

It looks to me like the plots meant to be generated by nn_tc_ever_v_never and structural_prior_min_freq are purported to only look at target ranks for the generative model, not others (pubchem/addcarbon etc), so I've incorporated those filters here.

The change in plots for PED dataset (enum factor 100) are:

Before

ratio_ever_v_never p_ever_generated top_k_min_freq

After

ratio_ever_v_never top_k_min_freq p_ever_generated