random behavior in create_training_sets

skinniderlab / CLM

MIT License

0 stars 0 forks source link

random behavior in create_training_sets #220

Closed vineetbansal closed 1 month ago

vineetbansal commented 2 months ago

create_training_sets sets np.random.. at one point. The random seed should really be set by the main function instead.

Once we do this correctly, all existing tests should still pass if the test uses set_seed before invoking the create_training_sets function. Any other behavior is likely a bug.

vineetbansal commented 1 month ago

fixed in 9982d943ea977d6e9e05c028e5f4ca563ef57168. Thanks @adichaloo !