search

skinniderlab / CLM

MIT License
0 stars 0 forks source link

max_epochs default #226

Closed skinnider closed 1 month ago

skinnider commented 1 month ago

Is there a reason this is set to 100 by default? I usually have it at some very high number e.g. 99999. https://github.com/skinniderlab/CLM/blob/0f699acaa1afa28bf64d0545bdbf38b7dd8d6fb7/workflow/config/config.yaml#L32C3-L32C13

vineetbansal commented 1 month ago

I think we were initially scared of 99999. Since the actual number of iterations we've seen in our runs are ~50 before patience kicks in, I think it's fine to change the default. PR #229 does this now.