skinniderlab / CLM

MIT License
0 stars 0 forks source link

Introducing plot command and plot for calculate outcomes #96

Closed anushka255 closed 5 months ago

anushka255 commented 5 months ago

Introducing plot command instead of --plot option. Running the following command after generating the model evaluation files will generate all the figures relating a particular evaluation (calculate_outcomes in this case):

clm plot calculate_outcomes --outcome_dir /path/to/model_evaluation/ --output_dir /path/to/figures
vineetbansal commented 5 months ago

My thinking is that whatever command is currently generating the files for a plot (calculate_outcomes in this case?) might as well unconditionally plot it and save the .png (in a default file location, unless overridden). This should prevent proliferation of these commands (and all their associated baggage) going forward, unless you have a good reason to keep things this way for now.

anushka255 commented 5 months ago

My thought was it would give more flexibility in terms of plotting the figures. The figures also require aggregation of all the generated files, so we need each of these commands to run to completion to be able to plot the figures.

vineetbansal commented 5 months ago

sounds good - I'll merge once whatever is holding up the CI is fixed.