search

skinny85 / specnaz

Library for writing beautiful, RSpec/Jasmine/Mocha/Jest-style specifications in Java, Kotlin and Groovy
Other
34 stars 8 forks source link

Change the shouldThrow method to return an instance of the ThrowableExpectations class #6

Closed skinny85 closed 6 years ago

skinny85 commented 6 years ago

This is the continuation of Pull Request #4 (unfortunately, I can't update the PR started by Roberto).

skinny85 commented 6 years ago

Hey Roberto,

this implements the version we talked about in #4 . I rebased it on top of develop, as that's the code for the next release (1.2). It contains some changes when compared to master (mainly the ability to focus and exclude tests).

Can you review the changes, and let me know what you think? I'm curious about your opinion if this does what you originally intended :).

Thanks! Adam

rlbisbe commented 6 years ago

I've gone through it, and I liked it, a lot. It looks very clean and also opens the possibility to expand it ever further.

I wonder if we can use the same approach for other "should", or if it would make any sense at all.

In any case. 🚢

skinny85 commented 6 years ago

Thanks Roberto :) I'm merging this one then.