added support for numeric ids in _valueChanged handler

skinnybrit51 / editable-grid

Bootstrap grid with CRUD functionality.

MIT License

30 stars 4 forks source link

added support for numeric ids in _valueChanged handler #103

Closed svzi closed 6 years ago

svzi commented 6 years ago

I added support for numeric id's in _valueChanged handler. The original implementation crashed with numeric id's instead of string values. I'm using this grid in combination with a MySQL database and numeric keys. So this could be helpful to someone else as well.

skinnybrit51 commented 6 years ago

Unit test failed. Are you passing an actual number or a string number?

svzi commented 6 years ago

Good find, sorry, I didn't run the tests the last time. After a quick research I found out that the underscore version of isNaN() isn't working the way I expected it. So I switched to the builtin isNaN() function and now the checks are passing. Thanks for the info! 👍

svzi commented 6 years ago

Any update on this? Did this PR still miss something? If so, please let me know.