skip-mev / connect

A general purpose oracle leveraging ABCI++
Other
80 stars 50 forks source link

fix: only allow upper tickers #716

Closed aljo242 closed 2 months ago

aljo242 commented 2 months ago

Closes CON-1719

github-actions[bot] commented 2 months ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (2)

TESTADDRESS TESTCHAIN

These words are not needed and should be removed alr anypb anys arounds badprice beginblocker bitsets cdb cmthash commitheight Concluson coretypes cvp ddd Devation dfa endblocker goautoneg GOM goodprice IDbz incentivize initgenesis Macbook msc munnerz oraclevetypes outpkg pbk pkany pkb pkv Prce pubkeys pvks sdktypes statelessly submitters tmhash UIDs underperform unescrow unmashalling VEbz vih voteaggregator wrt

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands ... in a clone of the [git@github.com:skip-mev/connect.git](https://github.com/skip-mev/connect.git) repository on the `fix/only-upper-tickers` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' | perl - 'https://github.com/skip-mev/connect/actions/runs/10619302832/attempts/1' ```
**OR** To have the bot accept them for you, comment in the PR quoting the following line: @check-spelling-bot apply [updates](https://github.com/skip-mev/connect/actions/runs/10619302832/attempts/1).
Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (800) from .github/actions/spelling/expect.txt and **unrecognized words** (2) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|8|4| [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|5|4| [cspell:java/src/java.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java.txt)|2464|5|3| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|4|3| [cspell:java/src/java-terms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java-terms.txt)|920|4|1| Consider adding them (in `.github/workflows/spell.yml`) in `jobs:`/`build:` to `extra_dictionaries`: ``` yml cspell:python/src/python/python-lib.txt cspell:fullstack/dict/fullstack.txt cspell:java/src/java.txt cspell:filetypes/filetypes.txt cspell:java/src/java-terms.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spell.yml`): ``` yml check_extra_dictionaries: '' ```
Warnings (1) #### See the [:open_file_folder: files](https://github.com/skip-mev/connect/pull/716/files/) view, the [:scroll:action log](https://github.com/skip-mev/connect/actions/runs/10619302832/job/29436559700#step:4:1), or [:memo: job summary](https://github.com/skip-mev/connect/actions/runs/10619302832/attempts/1#summary-29436559700) for details. [:warning: Warnings](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:warning: no-newline-at-eof](https://docs.check-spelling.dev/Event-descriptions#no-newline-at-eof) | 3 See [:warning: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../../../README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.
:steam_locomotive: If you're seeing this message and your PR is from a branch that doesn't have check-spelling, please merge to your PR's base branch to get the version configured for your repository.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.97%. Comparing base (9e90c33) to head (d0dd961). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #716 +/- ## ========================================== - Coverage 56.01% 55.97% -0.05% ========================================== Files 206 206 Lines 11481 11475 -6 ========================================== - Hits 6431 6423 -8 - Misses 4451 4452 +1 - Partials 599 600 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.