search

skip-mev / connect

A general purpose oracle leveraging ABCI++
Other
79 stars 44 forks source link

feat: validation service #724

Closed aljo242 closed 1 week ago

aljo242 commented 2 weeks ago

Spins up and internal validation service that can introspect the live prices the sidecar is producing.

If any of the prices is below our configured liveness threshold (99%, perhaps this should be stricter), the process will terminate itself.

If all prices are valid after a configured amount of time, the process will gracefully tear down and end sucessfully.

github-actions[bot] commented 2 weeks ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

libhttp

To accept these unrecognized words as correct, you could run the following commands ... in a clone of the [git@github.com:skip-mev/connect.git](https://github.com/skip-mev/connect.git) repository on the `chore/debug-timeout` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' | perl - 'https://github.com/skip-mev/connect/actions/runs/10706767517/attempts/1' ```

OR

To have the bot accept them for you, comment in the PR quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (755) from .github/actions/spelling/expect.txt and **unrecognized words** (1) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|8|4| [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|5|4| [cspell:java/src/java.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java.txt)|2464|5|3| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|4|3| [cspell:java/src/java-terms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java-terms.txt)|920|4|1| Consider adding them (in `.github/workflows/spell.yml`) in `jobs:`/`build:` to `extra_dictionaries`: ``` yml cspell:python/src/python/python-lib.txt cspell:fullstack/dict/fullstack.txt cspell:java/src/java.txt cspell:filetypes/filetypes.txt cspell:java/src/java-terms.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spell.yml`): ``` yml check_extra_dictionaries: '' ```
Warnings (1) #### See the [:open_file_folder: files](https://github.com/skip-mev/connect/pull/724/files/) view, the [:scroll:action log](https://github.com/skip-mev/connect/actions/runs/10706767517/job/29685230124#step:4:1), or [:memo: job summary](https://github.com/skip-mev/connect/actions/runs/10706767517/attempts/1#summary-29685230124) for details. [:warning: Warnings](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:warning: no-newline-at-eof](https://docs.check-spelling.dev/Event-descriptions#no-newline-at-eof) | 3 See [:warning: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../../../README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.

:steam_locomotive: If you're seeing this message and your PR is from a branch that doesn't have check-spelling, please merge to your PR's base branch to get the version configured for your repository.

github-actions[bot] commented 2 weeks ago

@check-spelling-bot Report

:red_circle: Please review

See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.

Unrecognized words (1)

libhttp

To accept these unrecognized words as correct, you could run the following commands ... in a clone of the [git@github.com:skip-mev/connect.git](https://github.com/skip-mev/connect.git) repository on the `chore/debug-timeout` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' | perl - 'https://github.com/skip-mev/connect/actions/runs/10706806834/attempts/1' ```

OR

To have the bot accept them for you, comment in the PR quoting the following line: @check-spelling-bot apply updates.

Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary This includes both **expected items** (755) from .github/actions/spelling/expect.txt and **unrecognized words** (1) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|8|4| [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|5|4| [cspell:java/src/java.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java.txt)|2464|5|3| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|4|3| [cspell:java/src/java-terms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java-terms.txt)|920|4|1| Consider adding them (in `.github/workflows/spell.yml`) in `jobs:`/`build:` to `extra_dictionaries`: ``` yml cspell:python/src/python/python-lib.txt cspell:fullstack/dict/fullstack.txt cspell:java/src/java.txt cspell:filetypes/filetypes.txt cspell:java/src/java-terms.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spell.yml`): ``` yml check_extra_dictionaries: '' ```
Warnings (1) #### See the [:open_file_folder: files](https://github.com/skip-mev/connect/pull/724/files/) view, the [:scroll:action log](https://github.com/skip-mev/connect/actions/runs/10706806834/job/29685356817#step:4:1), or [:memo: job summary](https://github.com/skip-mev/connect/actions/runs/10706806834/attempts/1#summary-29685356817) for details. [:warning: Warnings](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:warning: no-newline-at-eof](https://docs.check-spelling.dev/Event-descriptions#no-newline-at-eof) | 3 See [:warning: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.
If the flagged items are :exploding_head: false positives If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../../../README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.

:steam_locomotive: If you're seeing this message and your PR is from a branch that doesn't have check-spelling, please merge to your PR's base branch to get the version configured for your repository.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 12.06897% with 102 lines in your changes missing coverage. Please review.

Project coverage is 55.52%. Comparing base (fc4879a) to head (bf62b8b). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
service/validation/validation.go 17.14% 58 Missing :warning:
cmd/connect/main.go 0.00% 25 Missing :warning:
oracle/metrics/metrics.go 0.00% 12 Missing :warning:
pkg/http/address.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #724 +/- ## ========================================== - Coverage 55.97% 55.52% -0.45% ========================================== Files 206 208 +2 Lines 11475 11582 +107 ========================================== + Hits 6423 6431 +8 - Misses 4452 4552 +100 + Partials 600 599 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.