github-actions[bot]
commented
2 months ago @check-spelling-bot Report
:red_circle: Please review
See the :open_file_folder: files view, the :scroll:action log, or :memo: job summary for details.
Unrecognized words (2)
connectabci connecttypes
To accept these unrecognized words as correct, you could run the following commands
... in a clone of the [git@github.com:faddat/connect.git](https://github.com/faddat/connect.git) repository on the `patch-1` branch ([:information_source: how do I use this?]( https://docs.check-spelling.dev/Accepting-Suggestions)): ``` sh curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' | perl - 'https://github.com/skip-mev/connect/actions/runs/10715094427/attempts/1' ```Available :books: dictionaries could cover words (expected and unrecognized) not in the :blue_book: dictionary
This includes both **expected items** (755) from .github/actions/spelling/expect.txt and **unrecognized words** (2) Dictionary | Entries | Covers | Uniquely -|-|-|- [cspell:python/src/python/python-lib.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/python/src/python/python-lib.txt)|2417|8|4| [cspell:fullstack/dict/fullstack.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/fullstack/dict/fullstack.txt)|419|5|4| [cspell:java/src/java.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java.txt)|2464|5|3| [cspell:filetypes/filetypes.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/filetypes/filetypes.txt)|264|4|3| [cspell:java/src/java-terms.txt](https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/java/src/java-terms.txt)|920|4|1| Consider adding them (in `.github/workflows/spell.yml`) in `jobs:`/`build:` to `extra_dictionaries`: ``` yml cspell:python/src/python/python-lib.txt cspell:fullstack/dict/fullstack.txt cspell:java/src/java.txt cspell:filetypes/filetypes.txt cspell:java/src/java-terms.txt ``` To stop checking additional dictionaries, add (in `.github/workflows/spell.yml`): ``` yml check_extra_dictionaries: '' ```Warnings (1)
#### See the [:open_file_folder: files](https://github.com/skip-mev/connect/pull/728/files/) view, the [:scroll:action log](https://github.com/skip-mev/connect/actions/runs/10715094427/job/29709910858#step:4:1), or [:memo: job summary](https://github.com/skip-mev/connect/actions/runs/10715094427/attempts/1#summary-29709910858) for details. [:warning: Warnings](https://docs.check-spelling.dev/Event-descriptions) | Count -|- [:warning: no-newline-at-eof](https://docs.check-spelling.dev/Event-descriptions#no-newline-at-eof) | 3 See [:warning: Event descriptions](https://docs.check-spelling.dev/Event-descriptions) for more information.If the flagged items are :exploding_head: false positives
If items relate to a ... * binary file (or some other file you wouldn't want to check at all). Please add a file path to the `excludes.txt` file matching the containing file. File paths are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your files. `^` refers to the file's path from the root of the repository, so `^README\.md$` would exclude [README.md]( ../../../README.md) (on whichever branch you're using). * well-formed pattern. If you can write a [pattern](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples:-patterns) that would match it, try adding it to the `patterns.txt` file. Patterns are Perl 5 Regular Expressions - you can [test]( https://www.regexplanet.com/advanced/perl/) yours before committing to verify it will match your lines. Note that patterns can't match multiline strings.:steam_locomotive: If you're seeing this message and your PR is from a branch that doesn't have check-spelling, please merge to your PR's base branch to get the version configured for your repository.
codecov[bot]
When there are multiple modules in the same repository, Go has a strong preference for versioning each of them independently.
So, I think that this will allow users to import the correct version of the connect tests.
Here's an example of what I'm trying to address here:
* https://github.com/cosmos/ibc-go/blob/main/modules/capability/go.mod
So even though ibc-go is at v8, we can see that the capability module, which shares commits from ibc-go/v8 drops the /v8 part in its import url.
I think it is mainly just golang being odd, and that this will resolve some issues when external users and developers try to import connect's tests.