Open aljo242 opened 1 month ago
Attention: Patch coverage is 72.72727%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 57.40%. Comparing base (
efff2b1
) to head (2d6dc3a
).
Files with missing lines | Patch % | Lines |
---|---|---|
x/marketmap/keeper/keeper.go | 62.50% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes CON-1839
SetLastUpdated
for anySet
orRemove
calls in the keeper. (previously these calls were only done during the MsgServer which meant that hooks, or any keeper calls that are not part of a MsgServer call were not updating LastUpdated)LastUpdated
field. Use randomized blockheights instead of constantsNote, this fix is only for on-chain code, so a full upgrade would be needed. This is also state-breaking, so we will need to make a new
v3.x
release as anyv1
orv2
version of the code will result in disparate states (last updated will be updated differently).I will make another PR that will only updates the sidecar, which can be rolled out more quickly.