skip-mev / connect

A general purpose oracle leveraging ABCI++
Other
80 stars 50 forks source link

fix: last updated setting in `x/marketmap` keeper [DO NOT MERGE] #799

Open aljo242 opened 1 month ago

aljo242 commented 1 month ago

Closes CON-1839

Note, this fix is only for on-chain code, so a full upgrade would be needed. This is also state-breaking, so we will need to make a new v3.x release as any v1 or v2 version of the code will result in disparate states (last updated will be updated differently).

I will make another PR that will only updates the sidecar, which can be rolled out more quickly.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.40%. Comparing base (efff2b1) to head (2d6dc3a).

Files with missing lines Patch % Lines
x/marketmap/keeper/keeper.go 62.50% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #799 +/- ## ========================================== + Coverage 57.39% 57.40% +0.01% ========================================== Files 214 214 Lines 14844 14850 +6 ========================================== + Hits 8520 8525 +5 Misses 5710 5710 - Partials 614 615 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.