search

skip-mev / connect

A general purpose oracle leveraging ABCI++
Other
80 stars 50 forks source link

fix: sidecar no longer checks `LastUpdated` #800

Closed aljo242 closed 4 weeks ago

aljo242 commented 1 month ago

Part of CON-1839

This is a sidecar level fix that reverts the check of LastUpdated to checking equality of the incoming market map updates.

Factor out updating check to IsMarketMapValidUpdated which now has testing.

The market equality check can be reverted to the LastUpdated check once we are using on-chain logic with this PR.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 66.66667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 57.31%. Comparing base (1d27812) to head (46b8197). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
providers/providertest/provider.go 0.00% 9 Missing :warning:
oracle/market_mapper.go 81.25% 4 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #800 +/- ## ========================================== + Coverage 56.98% 57.31% +0.33% ========================================== Files 213 213 Lines 14801 14823 +22 ========================================== + Hits 8434 8496 +62 + Misses 5757 5713 -44 - Partials 610 614 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.