search

skip-mev / pob

Skip's protocol-owned MEV builder implementation
Apache License 2.0
54 stars 10 forks source link

Fees as `BigInt` instead of `sdk.Coin` #108

Open davidterpay opened 1 year ago

davidterpay commented 1 year ago

Since POB does not have multiple fee denominations, it probably makes more sense to simplify the interface and utilize BigInt instead. FWIW, this will definitely simplify integrations with EVM or other similar chains where expressing bids as sdk.Coins may not be trivial.

itsdevbear commented 1 year ago

@davidterpay you can use a comparable generic as well

https://go.dev/blog/comparable

itsdevbear commented 1 year ago

alternatively, we can define a custom Comparable interface and then write a small wrapper around sdk.Coins{} as the default.