skiphansen
commented
4 years ago I can't see any issues with that change. It's like a hard coded plain text string was adding any security anyway.
Open wd5m opened 4 years ago
skiphansen
commented
4 years ago I can't see any issues with that change. It's like a hard coded plain text string was adding any security anyway.
Skip, Dave C. has changed the IRLP reflector connection software to set SPEAKFREEE_CNAME environment variable to the IRLP "${CALLSIGN}" variable value. Previously IRLP (and EchoIRLP) set this environment variable value to the static string of "CALLSIGN". The new value causes theLinkbox ".users" command to list IRLP connections as IP addresses. Previously, IRLP connections were listed with their node number, e.g. stn1234, which is being passed in the SPEAKFREE_ID environment value.
Do you recall why or how the use of the "CALLSIGN" static string in tlb/tbd came about with IRLP/Speakdfreely and tlb/tbd? It's not part of speakfreely code, that I can find. I'm not sure why this affects the ".users" command, as I've not traced the tlb/tbd code. (I'm not a C++ programmer). It might be something that you implemented for EchoIRLP.
I'm trying to understand how adapting tlb/tbd to this change from IRLP might affect other uses of tlb/tbd. 06/17/2020 Update; I made a change, to remove/comment this bit of code, in conference.c. In testing with IRLP setting the SPEAKFREE_CNAME value to either "CALLSIGN" or the value from "${CALLSIGN}", this allwed tlb to display the expected results from .users command and in the list of connected nodes on echolink. Don't yet understand history of this bit of code being implemented. Unsure if removing this is the right response to the IRLP change.
/ if(!bFoundCallsign) { if(Callsign != NULL) { free(Callsign); Callsign = NULL; } // Only accept a password if the callsign is also specified if(pCC->Password != NULL) { free(pCC->Password); pCC->Password = NULL; } } / `