search

skippbox / ktune

Kubernetes applications tuning
http://www.skippbox.com
Apache License 2.0
28 stars 2 forks source link

canary deployment sets competing labels in replica set #12

Closed sebgoa closed 7 years ago

sebgoa commented 7 years ago

We end up with two deployments pointing to the new replica sets.

Hence it keeps getting scaled up and down.

So we need to remove all labels (for instance).

sebgoa commented 7 years ago

https://github.com/skippbox/ktune/blob/master/worker/canary.go#L109

sebgoa commented 7 years ago

modified the metadata label of the canary deployment to be properly identified and added example in README.

This is not a bug per se.

8a701ee947b7fb3de53d652e5e164aa9a9e45218