Closed James103 closed 9 months ago
I only tested it on 1.20.1, so it is very likely that it doesn't. I'll try to make a version for 1.19.2.
Did you use dependency overrides to make this work on 1.19.2? I am depending on 1.20.1, so I hope that this is actually enforced by Fabric.
I tried using a dependency override to remove all dependencies for this mod as they currently are. When starting up the client, the dependency check passed, as the dependencies for this mod were overridden with an empty object as follows.
{
"version": 1,
"overrides": {
"createfabricfixes": {
"depends": {}
}
}
}
However, the game crashes with several mixin errors. Attached is a log from a backup of the production instance where I tried to include the mod.
Thank you for testing. I'll try to make a 1.19.2 version.
Completed!
I still get the same error when taking items out of a contraption's storage and then disassembling. crash-2024-01-16_15.40.57-server.txt
Strange, I never got this kind of error (If you look closely, you can see that it happens in an other phase of disassembling). Which kind of contraption do you use, and which type of storage?
I assembled the most basic train with storage, shown through the attached picture and schematic. To reproduce:
Schematic file: train.zip
Same error on 1.20.1
[Server thread/ERROR]: Error executing task on Server
java.lang.IllegalArgumentException: Transfer variant may not be blank.
at net.fabricmc.fabric.api.transfer.v1.storage.StoragePreconditions.notBlank(StoragePreconditions.java:39) ~[fabric-transfer-api-v1-3.3.3+c81d263177-b6ab590a5b70cd3e.jar:?]
at net.fabricmc.fabric.api.transfer.v1.storage.StoragePreconditions.notBlankNotNegative(StoragePreconditions.java:58) ~[fabric-transfer-api-v1-3.3.3+c81d263177-b6ab590a5b70cd3e.jar:?]
at net.fabricmc.fabric.api.transfer.v1.item.base.SingleStackStorage.insert(SingleStackStorage.java:108) ~[fabric-transfer-api-v1-3.3.3+c81d263177-b6ab590a5b70cd3e.jar:?]
at net.fabricmc.fabric.impl.transfer.item.InventorySlotWrapper.insert(InventorySlotWrapper.java:81) ~[fabric-transfer-api-v1-3.3.3+c81d263177-b6ab590a5b70cd3e.jar:?]
at net.fabricmc.fabric.impl.transfer.item.InventorySlotWrapper.insert(InventorySlotWrapper.java:40) ~[fabric-transfer-api-v1-3.3.3+c81d263177-b6ab590a5b70cd3e.jar:?]
at net.fabricmc.fabric.api.transfer.v1.storage.base.CombinedStorage.insert(CombinedStorage.java:67) ~[fabric-transfer-api-v1-3.3.3+c81d263177-b6ab590a5b70cd3e.jar:?]
at com.simibubi.create.content.contraptions.MountedStorage.addStorageToWorld(MountedStorage.java:171) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.contraptions.MountedStorageManager.addStorageToWorld(MountedStorageManager.java:176) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.contraptions.Contraption.addBlocksToWorld(Contraption.java:1110) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.contraptions.AbstractContraptionEntity.disassemble(AbstractContraptionEntity.java:667) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.trains.entity.Train.disassemble(Train.java:720) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.trains.station.StationBlockEntity.tryDisassembleTrain(StationBlockEntity.java:405) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.trains.station.StationBlockEntity.enterAssemblyMode(StationBlockEntity.java:359) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.trains.station.StationEditPacket.applySettings(StationEditPacket.java:129) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.content.trains.station.StationEditPacket.applySettings(StationEditPacket.java:13) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at com.simibubi.create.foundation.networking.BlockEntityConfigurationPacket.lambda$handle$0(BlockEntityConfigurationPacket.java:44) ~[create-fabric-0.5.1-d-build.1161+mc1.20.1(1).jar:?]
at net.minecraft.class_3738.run(class_3738.java:18) ~[server-intermediary.jar:?]
at net.minecraft.class_1255.method_18859(class_1255.java:156) ~[server-intermediary.jar:?]
at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:782) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:164) ~[server-intermediary.jar:?]
at net.minecraft.class_1255.method_16075(class_1255.java:130) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:764) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:758) ~[server-intermediary.jar:?]
at net.minecraft.class_1255.method_18857(class_1255.java:139) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:743) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:675) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[server-intermediary.jar:?]
at java.lang.Thread.run(Thread.java:840) ~[?:?]
Released a new version for 1.20 that should fix this issue. 1.19.2 is still wip.
Done (hopefully)
When disassembling one of the contraptions in my survival world, I got the same error as https://github.com/Fabricators-of-Create/Create/issues/1080 (
java.lang.IllegalArgumentException: Transfer variant may not be blank
) and the contraption I tried to disassemble effectively destroyed itself. This didn't outright crash the game, but it did result in me losing several hours worth of resources while I rebuilt the contraption.Does this mod work on 1.19.2? If not, would it be possible to make this mod work on 1.19.2, in order to avoid situations like the one described above from reoccurring?
Edit: More specifically, I was using Create Mod version
Create Mod 0.5.1-c-build.1160+mc1.19.2
and Fabric API versionFabric API 0.76.1+1.19.2
, the former of which is the latest version that works on 1.19.2.