skiptools / skipapp-bookings

Demonstration of a full-featured Skip dual-platform app project for iOS and Android
10 stars 1 forks source link

Extreme lag on android #3

Open J05HI opened 1 month ago

J05HI commented 1 month ago

The android debug build is lagging extremely. Take a look at the recording: https://github.com/user-attachments/assets/a64fac82-1cb9-4769-bef5-bd09597fc1ba

The release build can't be installed: Screenshot_20240806-183920.png

aabewhite commented 1 month ago

Thanks for the heads-up! To help us investigate: what device/emulator are you using? And is there any chance it's super low on disk space?

aabewhite commented 1 month ago

Also do you see any improvement in scrolling the city list when you hit the button in the upper right to switch to "poster" view mode?

J05HI commented 1 month ago

Thanks for the heads-up! To help us investigate: what device/emulator are you using? And is there any chance it's super low on disk space?

I'm on a Pixel 7 Pro, no emulator. I have about 50 GB free space.

J05HI commented 1 month ago

Also do you see any improvement in scrolling the city list when you hit the button in the upper right to switch to "poster" view mode?

A little bit. But not really.

J05HI commented 1 month ago

Why can't I install the release build? Is it corrupted?

marcprux commented 1 month ago

Why can't I install the release build? Is it corrupted?

The problem with the release build is likely that it is unsigned. The debug build is signed, but with a key that (likely) changes every time, so you wouldn't be able to update the app. If you want to try with the release build, you could download the apk locally and manually sign it, and/or just build the skipapp-bookings app yourself from Xcode with the Release configuration (in which case it would sign it with a temporary key).

J05HI commented 1 month ago

Why can't I install the release build? Is it corrupted?

The problem with the release build is likely that it is unsigned. The debug build is signed, but with a key that (likely) changes every time, so you wouldn't be able to update the app. If you want to try with the release build, you could download the apk locally and manually sign it, and/or just build the skipapp-bookings app yourself from Xcode with the Release configuration (in which case it would sign it with a temporary key).

I just signed the release build. Sadly it has the same lag. The showcase app installed through PlayStore works smoothly. Have you tested it on an android phone or only simulator?

J05HI commented 1 month ago

@aabewhite @marcprux Any news for the lag problem?

aabewhite commented 1 month ago

Tha is for following up. We isolated and fixed one source of slowdown (SwiftUI's implicit localization of Text). We'll continue to investigate and improve things over time