search

skirsch / Czech

7 stars 4 forks source link

xz version? #1

Closed niallyoung closed 1 month ago

niallyoung commented 1 month ago

G'day Steve, having some trouble on macOS with xz - what version/platform are you running on?

Would you be open to a PR, run xz via Docker image or similar - make this a bit more portable?

niall@localhost ~/git/Czech/code (main) $ make
Expanding source data file...
xz: ../data/CR_records.csv.xz: File format not recognized
make: *** [../data/CR_records.csv] Error 1

niall@localhost ~/git/Czech/data (main) $ xz -dk CR_records.csv.xz 
xz: CR_records.csv.xz: File format not recognized

# alternatives 
niall@localhost ~/git/Czech/data (main) $ brew install unar atool

niall@localhost ~/git/Czech/data (main) $ unar CR_records.csv.xz 
CR_records.csv.xz: Couldn't recognize the archive format.

niall@localhost ~/git/Czech/data (main) $ atool -x CR_records.csv.xz 
xz: CR_records.csv.xz: File format not recognized
atool: xz ... | CR_records.csv ...: non-zero return-code
skirsch commented 1 month ago

sure. I have managed PR's before but I can figure it out it out. Let me know if I have to do something to enable it.

niallyoung commented 1 month ago

Is data/CR_records.csv.xz corrupted, or using some strange new version? If not, it might be worth looking at bzip2 or another compression format - just for portability and ensuring we can all replicate

skirsch commented 1 month ago

standard xz

never had any problems.

if you can get as good compression on bzip2, open to using that.

niallyoung commented 1 month ago

Any idea what version of xz/xz-utils you're using locally? There was a backdoor introduced in 5.6.0/5.6.1 https://en.wikipedia.org/wiki/XZ_Utils_backdoor

(once I can decompress I'll compare to bz2 and push up a PR 👍 )

skirsch commented 1 month ago

stk@stk-home:~/truenas-s3/backup-data/extracted files$ xz --version xz (XZ Utils) 5.4.1 liblzma 5.4.1

skirsch commented 1 month ago

i run Debian under WSL on Windows. works like a charm.

niallyoung commented 1 month ago

ohhhhhhh I see the issue now, download via clone might be censored vs. https :\

https://github.com/skirsch/Czech/pull/2

skirsch commented 1 month ago

so do you still want me to add your pull request? It's sitting in the queue right now.. haven't looked at it yet.

skirsch commented 1 month ago

ok I merged in your changes. Thanks.

Give me a call when you get a moment: 650-279-1008.