skiselev / 8088_bios

BIOS for Intel 8088 based computers
GNU General Public License v3.0
515 stars 61 forks source link

A few incorrect entries in scan_xlat_table #19

Closed horkthane closed 1 year ago

horkthane commented 1 year ago

Short version, I was trying to play Might & Magic, and CTRL-B was being interpreted as CTRL-F. Using a keychecker, I discovered CTRL-V was also being interpreted as CTRL-F. I think I see some erroneous entries in scan_xlat_table. The ascii return for CTRL-V, CTRL-F and CTRL-B are all 0x06, where as on other machines I test against, they are 0x02 for CTRL-B, 0x06 for CTRL-F and 0x16 for CTRL-V. If I'm reading the scan_xlat_table correctly, the ascii return for all these is 0x06.

skiselev commented 1 year ago

Thank you for reporting this issue and fixing it! You are absolutely correct regarding the codes for Ctrl+(Letter). They start from 0x01 for Ctrl-A, increment for the each consecutive letter, and end with 0x1A for Ctrl-Z