search

skiselev / 8088_bios

BIOS for Intel 8088 based computers
GNU General Public License v3.0
513 stars 61 forks source link

Building on macOS #57

Closed Yrouel closed 8 months ago

Yrouel commented 9 months ago

I wrote the instructions to build this on macOS using Homebrew as the basis to install everything else that's necessary.

I didn't just make a pull request because while building the project works per se there is some quirkiness in the tr utility included in macOS (Sonoma in my case but I suspect it applies to other versions as well) in that LANG=C is seemingly ignored and the result is that the output of for example dd if=/dev/zero ibs=1k count=40 | LANG=C tr "\000" "\377" is 0xC3BF instead of 0xFF which produces invalid binaries. Using LC_ALL=C instead fixes the problem.

So if LC_ALL=C is also applicable to Linux without breaking anything consider using that instead to make the build process compatible with macOS without a special case for it

Build_Instructions-macOS.md CMakeLists.txt

skiselev commented 9 months ago

Thanks for the LC_ALL=C suggestion! I'll test it on Linux and if that works, I'll modify the CMakeLists.txt

skiselev commented 8 months ago

Fixed in https://github.com/skiselev/8088_bios/commit/a03b60b6cef69a64ec2384f07534d3943a0d3775