search

skiselev / 8088_bios

BIOS for Intel 8088 based computers
GNU General Public License v3.0
513 stars 61 forks source link

Keyboard buffer reset #65

Open jinshin opened 5 months ago

jinshin commented 5 months ago

Hi Sergey! Not a bug or issue, just a quick question: What is the actual purpose of https://github.com/skiselev/8088_bios/blob/8fd8cea2bbb94fb0e0ba03ed7d40034ea125c5d8/src/bios.asm#L1057-L1065 It's called right before keyboard buffer reset, so i think it's not needed, unless you wanted to do a stuck key detect there?

Also a suggestion - clean up keyboard buffer before entering settings loop, as entering a key several times causes menu reprint and that is quite slow thing. Like this:

.menu_loop:
    mov si,msg_set_prompt
    call    print

.menu_input:                ; cleanup buffer before start preocessing input
    mov ah,01
    int 16h
    jz  .menu_next
    mov ah,00
    int 16h
    jmp .menu_input
.menu_next: