search

skishore / inkstone

Learn Chinese on the go - no Internet connection required!
https://www.skishore.me/inkstone/
GNU General Public License v3.0
374 stars 92 forks source link

upgraded to Meteor v1.7 #25

Open JonathanLehner opened 6 years ago

JonathanLehner commented 6 years ago

I upgraded to Meteor v1.7 and fixed the resulting errors. Would be cool if you could look at the handling of "build-extras.gradle", which seems necessary to make it compile.

skishore commented 6 years ago

Hey, thanks for doing that!

The reason I've been holding off on updating Meteor here is that it necessitates updates throughout the toolchain - I would need to install a new Android SDK, a new version of Xcode, etc. There's a forced upgrade coming in a couple of months, so I was just going to do it then.

Have you built this version on both Android and iOS?

JonathanLehner commented 6 years ago

hi Shaunak! Sorry for my late reply. I tested both Android and IOS. You have to be a bit careful with cordova versions and android sdk though, since these seem to be relevant for build success. The appropriate cordova version should be set in the updated package.json file. There might be some gradle issues, so for me to build I had to add build-extras.gradle (see files) to .meteor/local/cordova-build/platforms/android/ With that it builds successfully on both Android and IOS. I tested it again just now.

If you have any issues with building feel free to let me know!

Best wishes, Jonathan