search

skishore / makemeahanzi

Free, open-source Chinese character data
https://www.skishore.me/makemeahanzi/
Other
1.85k stars 464 forks source link

SVG y-axes #10

Closed nycoliver closed 8 years ago

nycoliver commented 8 years ago

Hi thanks for the fantastic library!!

Just wondering why the svg y axes are inverted. It would be nice to render them without applying a transform each time.

Thanks

skishore commented 8 years ago

Hey, you raise an excellent point - there's no good reason for the y-axis to be inverted in the dataset.

I wrote a tool to generate this data, and within that tool it makes sense for the y-axis to be inverted, because that's the coordinate system that the TrueType font I derived these graphics from uses. However, there's a clearly delineated export step in this tool, and at that point, it would be easy to correct the coordinate system for consumers.

If you're willing to submit a pull request, I'd be happy to take a look! If not, I will probably get to this sometime myself.

nycoliver commented 8 years ago

Makes sense, will submit a pull request if I have time. Thanks again for the library, it's an incredible resource! Really appreciate the work.