search

skittles9823 / QuickSwitch

857 stars 41 forks source link

Not compatible with latest Magisk #73

Open hexdefined opened 2 months ago

hexdefined commented 2 months ago

Magisk removed the NVBASE variable in https://github.com/topjohnwu/Magisk/commit/d33b077a13b34691a7f1fd3643336e09383ced78, causing get_modpath.sh in the app to fail, because it uses util_functions.sh and assumes NVBASE has been set.

get_modpath.sh[40]: [: 30: unexpected operator/operand
/modules_update/quickswitch
/modules/quickswitch
osm0sis commented 1 month ago

Can confirm this is the cause of most of the recent "Oops" error related regressions/issues. @skittles9823 @paphonb

Until the QuickSwitch app gets fixed users can add the following line to the bottom of /data/adb/magisk/util_functions.sh and it should get things working: 

NVBASE=/data/adb
FERFAIL-TXZ commented 6 days ago

Can confirm this is the cause of most of the recent "Oops" error related regressions/issues. @skittles9823 @paphonb

Until the QuickSwitch app gets fixed users can add the following line to the bottom of /data/adb/magisk/util_functions.sh and it should get things working:

NVBASE=/data/adb

This worked for me, thanks!