Compiling error

[Dig-pestroyer]

Having this issue while trying to compile the firmware

Compiling: keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c                                  keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c:173:6: error: conflicting types for 'rgb_matrix_indicators_advanced_user'
  173 | bool rgb_matrix_indicators_advanced_user(uint8_t led_min, uint8_t led_max) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from quantum/quantum.h:36,
                 from keyboards/gmmk/gmmk2/gmmk2.h:19,
                 from keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c:17:
quantum/rgb_matrix/rgb_matrix.h:137:6: note: previous declaration of 'rgb_matrix_indicators_advanced_user' was here
  137 | void rgb_matrix_indicators_advanced_user(uint8_t led_min, uint8_t led_max);
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 [ERRORS]
 |
 |
 |
make[1]: *** [builddefs/common_rules.mk:456: .build/obj_gmmk_gmmk2_p96_ansi_default/keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.o] Error 1
Make finished with errors
make: *** [Makefile:413: gmmk/gmmk2/p96/ansi:default] Error 1

[skitzo2000]

@Dig-pestroyer can you switch to this branch and see if that fixes the issue: https://github.com/skitzo2000/GMMK2-96/tree/5-Compiling-error--RGBMatrix-fix

[Dig-pestroyer]

This is what I'm getting now

Compiling: keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c                                  keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c: In function 'rgb_matrix_indicators_advanced_user':
keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c:217:12: error: 'return' with a value, in function returning void [-Werror=return-type]
  217 |     return false;
      |            ^~~~~
keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.c:173:6: note: declared here
  173 | void rgb_matrix_indicators_advanced_user(uint8_t led_min, uint8_t led_max) {
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1.exe: all warnings being treated as errors
 [ERRORS]
 |
 |
 |
make[1]: *** [builddefs/common_rules.mk:456: .build/obj_gmmk_gmmk2_p96_ansi_default/keyboards/gmmk/gmmk2/p96/ansi/keymaps/default/keymap.o] Error 1
Make finished with errors
make: *** [Makefile:413: gmmk/gmmk2/p96/ansi:default] Error 1

[skitzo2000]

I made one more tweak, can you please repull the branch for the latest updates and give it another go. Thanks!

[Dig-pestroyer]

That did the trick, thank you so much!