Closed cpenning closed 8 years ago
I've made a couple of comments, can you check, then will merge.
Cheers,
P
Sure -- I was trying to keep the merge as consistent with viktorbjorklund as possible for this merge, but you are correct that it will play twice -- will disable ivona by default. And also the "extra space" pynova shouldn't be on that line at all -- it is installed in the following optional section. Will credit viktor and me -- may wait until I add a real feature first.
Future versions will have an ordered preference of tts engines (plus a net status check, as I found out yesterday when I lost my internet that it doesn't sound!)
This is great. Thanks so much for your help on this.
P
On Thu, Mar 10, 2016 at 6:38 AM, Craig Pennnington <notifications@github.com
wrote:
Sure -- I was trying to keep the merge as consistent with viktorbjorklund as possible for this merge, but you are correct that it will play twice -- will disable ivona by default. And also the "extra space" pynova shouldn't be on that line at all -- it is installed in the following optional section. Will credit viktor and me -- may wait until I add a real feature first.
Future versions will have an ordered preference of tts engines (plus a net status check, as I found out yesterday when I lost my internet that it doesn't sound!)
— Reply to this email directly or view it on GitHub https://github.com/skiwithpete/alarmpi/pull/7#issuecomment-194802582.
fixes #5, merges #2