refactor(be): merge client problem repository into service - Githubissues

skkuding / codedang

Online Judge for SKKU

https://codedang.com

MIT License

44 stars 9 forks source link

refactor(be): merge client problem repository into service #2197

Closed mnseok closed 1 week ago

mnseok commented 1 week ago

Description

client problem 모듈의 prisma 호출 부분이 repository로 분리되어있는 것을 합쳤습니다.
dto에서 class-validator를 사용하여 response를 filtering 하던 것을 service 내에서 처리해서 올바른 type으로 return하도록 수정하였습니다.

Additional context

리뷰 이후 수정을 위해 기존 코드를 주석처리, 남겨둔 상태입니다. 리뷰 이후에 삭제할 예정입니다.

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines
[x] Read the Contributing Guidelines and follow the Commit Convention
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.