skkwan / phase2-l1Calo-analyzer

0 stars 2 forks source link

New digitized collections cannot be included in the event content #13

Closed skkwan closed 7 months ago

skkwan commented 7 months ago

Artur opened a PR to include the new collections in the event content: https://github.com/cms-sw/cmssw/pull/43872 However, the tests fail since the digitized objects don’t have the proper dictionary for the ap_uint<64>. I assume you could persist one (or more) built-in uint type and convert to ap_uint when needed. Could you have a look and propose a fix? Saving the products to disk is crucial for downstream consumers.

unsigned long long int is 64 bits.

To-do

skkwan commented 7 months ago

Switched to unsigned long int [1] and in a local test with a keep command [2], the digitizing error is gone [1] https://github.com/skkwan/cmssw/commit/1b4ca950fc69aa358b95a2dd57e4e9148c46b4b2 [2] https://github.com/skkwan/phase2-l1Calo-analyzer/blob/fix-digitized-collections/test/test-singleAnalyzer.py#L67-L82

Marking issue as closed.