skkwan / phase2-l1Calo-analyzer

0 stars 2 forks source link

Avoid reusing label names for objects #15

Closed skkwan closed 8 months ago

skkwan commented 9 months ago

Lastly, could you review all the label names of the objects to avoid using the same one more than once (this is the case of the “RCT” and “GCT” labels used for “L1EGXtalClusters” and “L1CaloTowers”: https://github.com/cms-l1t-offline/cmssw/blob/l1t-integration-CMSSW_13_2_0_pre3/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc#L501

https://github.com/cms-l1t-offline/cmssw/blob/l1t-integration-CMSSW_13_2_0_pre3/L1Trigger/L1CaloTrigger/plugins/Phase2L1CaloEGammaEmulator.cc#L632

Having the same label doesn’t allow the collection to be fed to NanoAOD-like ntuplizers. Always about the flags, are the Egamma collection and the CaloCrystalCluster 100% consistent?

Screenshot 2024-02-16 at 15 45 29 Screenshot 2024-02-16 at 15 45 53
skkwan commented 8 months ago

Included unique labels for the RCT and GCT output collections [1] [1] https://github.com/skkwan/cmssw/commit/a68ce53cd8912fa9b49fd442b481e232932107a3