search

sklarsa / django-sendgrid-v5

An implementation of Django's EmailBackend compatible with sendgrid-python v5+
MIT License
318 stars 54 forks source link

Test Sendgrid v6 compatability #52

Closed sklarsa closed 5 years ago

sklarsa commented 5 years ago

https://github.com/sendgrid/sendgrid-python/releases/tag/v6.0.2

Also consider renaming the project to something more generic

RyanNoelk commented 5 years ago

FYI, there is a breaking change in this. You are trying to import ASM which has been renamed to Asm in Sendgrid 6. See:

I've restricted the sendgrid dep to sendgrid==5.6.0 in my requirements file, which makes everything happy again.

Thanks for the project tho :)

sklarsa commented 5 years ago

Thanks for the heads up! I figured something would break with this major version change. I’ll try to make this compatible with v5 and v6 since I don’t expect everyone to upgrade immediately

On Apr 3, 2019, at 9:30 AM, Ryan Noelk notifications@github.com wrote:

FYI, there is a breaking change in this. You are trying to import ASM which has been renamed to Asm in Sendgrid 6. See:

https://github.com/sklarsa/django-sendgrid-v5/blob/master/sendgrid_backend/mail.py#L18 https://github.com/sendgrid/sendgrid-python/blob/master/sendgrid/helpers/mail/asm.py#L5 I've restricted the sendgrid dep to sendgrid==5.6.0 in my requirements file, which makes everything happy again.

Thanks for the project tho :)

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

thinkingserious commented 5 years ago

Feel free to tag me if you have any questions (I am the maintainer for the sendgrid-python SDK). Thank you!

sklarsa commented 5 years ago

Thanks! I have a branch with tests almost passing here https://github.com/sklarsa/django-sendgrid-v5/pull/53. I just want some time to go over the changes to make sure that we don't break any existing functionality for anyone

On Wed, Apr 3, 2019 at 4:15 PM Elmer Thomas notifications@github.com wrote:

Feel free to tag me if you have any questions (I am the maintainer for the sendgrid-python SDK). Thank you!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/sklarsa/django-sendgrid-v5/issues/52#issuecomment-479642131, or mute the thread https://github.com/notifications/unsubscribe-auth/AB1xRfCYfk5XziKkzHbE8MEOG8o-CXaIks5vdQvzgaJpZM4caOD8 .