Fixes outlined in pull #93

sklarsa / django-sendgrid-v5

An implementation of Django's EmailBackend compatible with sendgrid-python v5+

MIT License

318 stars 54 forks source link

Fixes outlined in pull #93 #94

Closed alichass closed 3 years ago

alichass commented 3 years ago

_build_sg_personalization "to" arg now changed to optional; either it or existing_personalizations must be set.
Prevent using .personalizations without tos set.
Prevent unnecessary resetting of tos when personalization is already constructed.
No longer provide tos if not set for personalizations. This is to prevent every personalization from being sent to every recipient in msg.to
Added/Changed some comments/docstrings to reduce ambiguity

sklarsa commented 3 years ago

LGTM, @alichass can you add some test cases to validate the new logic?

To run the tests, check out the instructions here

alichass commented 3 years ago

Hi I added the test to check the errors raised (the only new functionality I added really - as far as I can tell the existing tests cover the new logic) but for some reason when I run nosetests -c nose.cfg locally it doesn't seem to run the new tests (I checked this by adding an arbitrary assert that should have failed)

alichass commented 3 years ago

I also dont understand this

(for some reason this resolved itself on the new pull)