search

skleanthous / C4-PlantumlSkin

This library provides skinning to create C4 diagrams using PlantUml
MIT License
76 stars 14 forks source link

Internal queues have the wrong font color in sequence diagrams #18

Open smbecker opened 2 years ago

smbecker commented 2 years ago

image

skleanthous commented 2 years ago

Hey @smbecker, thank you for raising this issue.

Unfortunately, in the past it seems that plantuml doesn't always honour skin parameter settings. I am not sure this is one of those cases, but I will try later today to confirm, and see what I can do.

skleanthous commented 2 years ago

If you're running this locally, one thing you could try is update plantuml to its latest version and see if that works.

smbecker commented 2 years ago

I found that if I add the following, it fixes the queue font color.

skinparam queue {
    FontColor SYSTEM_FONT_COLOR
}

This seems to be missing from https://github.com/skleanthous/C4-PlantumlSkin/blob/master/src/items/sequence.puml

smbecker commented 2 years ago

I verified it here but I had to make some build changes to allow me to use the output from that branch. Not sure how valuable that would be to you. I can remove that stuff if you want and push a PR although I'm not entirely sure why VS Code seems to have completely reformatted the files that I touched.