search

sklose / NCalc2

expression evaluator for .NET with built-in compiler
MIT License
170 stars 58 forks source link

Enh: Expression.CacheLogging property added. #28

Closed DaveBlakeman closed 3 years ago

DaveBlakeman commented 5 years ago

Hi,

This small, simple change makes a significant performance increase when working with many cached values (thousands), and slow logging providers (e.g. visual studio).

sklose commented 5 years ago

Hi Dave,

thanks for your PR. Instead of adding the logging on/off property I actually wouldn't mind just removing the Debug statements. They are probably not very useful to begin with.

DaveBlakeman commented 5 years ago

Great stuff,

Thanks!

On Tue, 7 May 2019 at 00:22, Sebastian Klose notifications@github.com wrote:

Hi Dave,

thanks for your PR. Instead of adding the logging on/off property I actually wouldn't mind just removing the Debug statements. They are probably not very useful to begin with.

  • Sebastian

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sklose/NCalc2/pull/28#issuecomment-489822369, or mute the thread https://github.com/notifications/unsubscribe-auth/ACJWDQTOYUSNBMEUL3DQ3D3PUC4UVANCNFSM4HH4DHMA .

DaveBlakeman commented 3 years ago

Just tidying...