search

sklose / NCalc2

expression evaluator for .NET with built-in compiler
MIT License
166 stars 58 forks source link

Fix code analysys warnings & culture support #87

Closed Bykiev closed 5 months ago

Bykiev commented 6 months ago

This PR fixes some code analysis warnings and adds new constructor to Expression to allow passing the culture. Also some code cleanup. I've tried to avoid breaking changes, seems all should be fine.

Culture support was manually backported from NCalc #46 and NCalc #52

Bykiev commented 6 months ago

@sklose, @david-brink-talogy can you please review this PR?

Bykiev commented 6 months ago

For some reason AppVeyour reports an error, seems to be smth wrong with him

Bykiev commented 6 months ago

@david-brink-talogy, I've resolved all comments, can you please review it again?

Bykiev commented 6 months ago

@sklose, can you please review?