search

sklose / NCalc2

expression evaluator for .NET with built-in compiler
MIT License
171 stars 57 forks source link

Support natural logarithms #93

Closed Bykiev closed 8 months ago

Bykiev commented 8 months ago

Added support for natural logarithms.

Closes #18

david-brink-talogy commented 8 months ago

Is this intended as a nice-to-have like Log10? This should already be possible.

var expression = new Expression("Log(1, E)");
expression.Parameters["E"] = Math.E;
Bykiev commented 8 months ago

Is this intended as a nice-to-have like Log10? This should already be possible.

var expression = new Expression("Log(1, E)");
expression.Parameters["E"] = Math.E;

You're right, it's just a nice-to-have

david-brink-talogy commented 8 months ago

@sklose, This looks good and I can now merge as a contributor. Are there any activities I should be performing before or after merge?

sklose commented 8 months ago

@sklose, This looks good and I can now merge as a contributor. Are there any activities I should be performing before or after merge?

no, nothing more to do after merging. it will automatically publish to NuGet.