skltrading / connectorTrial

Test build
3 stars 18 forks source link

Kucoin connector implemented. #15

Open ItIsOHM opened 2 weeks ago

ItIsOHM commented 2 weeks ago

I have implemented the public connector with many good practices like types and guards and all other things. Working on the private connector now.

@skltrading please look into this and let me know of any issues :)

skltrading commented 1 week ago

Hey Rhythm,

Thank you for your submission, please book a slot in my calendar https://calendar.google.com/calendar/u/0/appointments/schedules/AcZssZ0xXATdE83dGytAzsIYVTyl-ZhU4xYymigJDElyGlypS4YPYOYlGNgLLwDqyD2uNF-AEZjcF0Hv

Kind regards Sam

On Wed, 16 Oct 2024 at 18:15, Rhythm Garg @.***> wrote:

I have implemented the public connector with many good practices like types and guards and all other things. Working on the private connector now.

@skltrading https://github.com/skltrading please look into this and let me know of any issues :)

You can view, comment on, or merge this pull request online at:

https://github.com/skltrading/connectorTrial/pull/15 Commit Summary

File Changes

(18 files https://github.com/skltrading/connectorTrial/pull/15/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/skltrading/connectorTrial/pull/15, or unsubscribe https://github.com/notifications/unsubscribe-auth/BADRNUW43BAKWVIXDWTUMGDZ32NJZAVCNFSM6AAAAABQB6CT6WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU4TENJTGI3DQOI . You are receiving this because you were mentioned.Message ID: @.***>

-- [image: sc] [image: icon] Samuel Lannaghan Director [image: icon] +447469877536 [image: icon] @.*** [image: icon] www.sklventures.io https://sklventures.io/ Institutional Infrastructure for Digital Assets [image: sc] https://www.sklventures.io/

[image: sc] https://calendar.app.google/8f9ArtSWgoc8piiQ6

[image: sc] https://sklventures.io/

[image: sc] https://www.linkedin.com/in/sam-lannaghan-152355231/ [image: sc] https://twitter.com/SKL_MM The content of this email is confidential and intended for the recipient specified in message only. It is strictly forbidden to share any part of this message with any third party, without a written consent of the sender. If you received this message by mistake, please reply to this message and follow with its deletion, so that we can ensure such a mistake does not occur in the future.

ItIsOHM commented 1 week ago

Hey @skltrading, please take a look at this PR and merge if it looks good to you :)