search

skmp / reicast-emulator

Reicast was a multiplatform Sega Dreamcast emulator
https://reicast.emudev.org
Other
1.1k stars 346 forks source link

Danb91/macos controller support #1905

Closed DanB91 closed 4 years ago

DanB91 commented 4 years ago

Adds PS4 and Xbox One controller support to the Mac version of Reicast

einsteinx2 commented 4 years ago

It looks like his PR only failed CI because Wercker failed to run do to something with the CI environment config (trying to install packages and waiting for user input for some reason), not because of the code. I tried to rerun it but it looks like I don't have permissions to do that as hitting the retry button isn't doing anything.

einsteinx2 commented 4 years ago

I've fixed the Wercker config in this PR: https://github.com/reicast/reicast-emulator/pull/1907

DanB91 commented 4 years ago

The wrecker config change was pushed into this PR. All checks are passed now. Now awaiting approval.

einsteinx2 commented 4 years ago

Sorry still haven’t gotten to test this with my PS4 controllers. I’ll test tomorrow then approve this after a final once over on the code.

einsteinx2 commented 4 years ago

Thanks @skmp, as soon as I get a chance to test today I'll get it merged in.