Update shortest_path.py - Githubissues

sknetwork-team / scikit-network

Graph Algorithms

Other

602 stars 67 forks source link

Update shortest_path.py #518

Closed hcars closed 2 years ago

hcars commented 2 years ago

Adding exception handling for NegativeCycleErrors to the shortest path computations.

Modifications:

Added exception handling inside of the shortest path computation code.

Impacted submodules:

(e.g. sknetwork.topology)

sknetwork.path

This pull request:

(your PR must match these criteria before review)

[ ] targets the develop branch
[ ] does not decrease code coverage
[ ] passes the tests
[ ] is documented and the documentation build passes
[ ] has PEP8-compliant code and explicit variable naming
[ ] has a tutorial (facultative but recommended)

Any doubts about some technicalities? Do not hesitate to look at the dedicated Wiki.

tbonald commented 2 years ago

Thanks for this PR. Please target the develop branch.