Louvain reh - Githubissues

sknetwork-team / scikit-network

Graph Algorithms

Other

602 stars 67 forks source link

Louvain reh #538

Closed Rajjaa closed 2 years ago

Rajjaa commented 2 years ago

Modifications:

Renamed the top-down version of Louvain from LouvainHierarchy to LouvainIteration
Added the Louvain implementation from sknetwork.clustering to sknetwork.hierarchy. And modified it to output a dendrogram instead of the labels of the last aggregation.
Updated the related tests and documentation

Impacted submodules:

sknetwork.hierarchy

Additional notes

Couldn't run the tests on my platform

This pull request:

(your PR must match these criteria before review)

[x] targets the develop branch
[ ] does not decrease code coverage
[ ] passes the tests
[ ] is documented and the documentation build passes
[ ] has PEP8-compliant code and explicit variable naming
[x] has a tutorial (facultative but recommended)

Any doubts about some technicalities? Do not hesitate to look at the dedicated Wiki.

tbonald commented 2 years ago

I prefer to keep Louvain in clustering and call it with n_aggregations=1 to get the hierarchy.