Feat/detect-break-graph-cycles - Githubissues

sknetwork-team / scikit-network

Graph Algorithms

Other

606 stars 66 forks source link

Feat/detect-break-graph-cycles #565

Closed peng-yiwen closed 7 months ago

peng-yiwen commented 7 months ago

Modifications:

(new algorithms, added tests or documentation)

New Function: Get cycles from a graph (directed or undirected) by using DFS
New Function: Break cycles for cyclic graphs (directed or undirected)
Test: Add tests for get_cycles and break_cycles from root
Tutorial: Add detect and break cycles instructions in the cycles tutorial notebook

Impacted submodules:

(e.g. sknetwork.topology)

sknetwork.topology

Additional Comments:

These new features target tree-alike graphs
Finish in a second for wikidata taxonomy, which can also serves as a new dataset

This pull request:

(your PR must match these criteria before review)

[x] targets the develop branch
[x] does not decrease code coverage
[x] passes the tests
[ ] is documented and the documentation build passes
[x] has PEP8-compliant code and explicit variable naming
[x] has a tutorial (facultative but recommended)

Any doubts about some technicalities? Do not hesitate to look at the dedicated Wiki.