skniro / UsefulFood-Reborn

MIT License
2 stars 1 forks source link

Portuguese (Brazil) translation + recipe fixes #1

Closed vico93 closed 1 year ago

vico93 commented 1 year ago

Partially based on vanilla's pt-br locale, and with a little bit of "artistic license" on some terms.

vico93 commented 1 year ago

I think i will redo the PR because it actually merged two commits that i felt need to be separate PRs. Sorry for that.

vico93 commented 1 year ago

Ah, sorry, dont know how to separate it. Will change the title to reflect the new context.

skniro commented 1 year ago

I think you should put fabric tags, lang files and recipes to resources path,not generated path.Because generated path's file all generation by fabric datagen. If you can change my datagen to tweaks recipes is better.

skniro commented 1 year ago

Just curious,why you want use shaped recipes not shapless recipes.

skniro commented 1 year ago

chocolatebar jelly oreo rawmarshmallow sugarcube trailmix 's recipes change i need a reason. chocolatemilkbottle I agree this change but i don't want use shaped recipes in this. Other change is approved.

vico93 commented 1 year ago

I think you should put fabric tags, lang files and recipes to resources path,not generated path.Because generated path's file all generation by fabric datagen. If you can change my datagen to tweaks recipes is better.

Ah, sorry, i'm not much familiarized with Fabric project structure, i found the corresponding files in generated so i thought it was the right place for them.

vico93 commented 1 year ago

Just curious,why you want use shaped recipes not shapless recipes.

In what recipes?

vico93 commented 1 year ago

chocolatebar jelly oreo rawmarshmallow sugarcube trailmix 's recipes change i need a reason. chocolatemilkbottle I agree this change but i don't want use shaped recipes in this. Other change is approved.

In general, not all recipes should be shapeless, because it can clash with recipes added by other mods or datapacks. Of course some simple ones or "straight-at-a-point" ones can be kept as shapeless, but the more ingredients the recipe has, its better for compatibility to make them shaped.

skniro commented 1 year ago

I still want not to change the chocolatebar jelly oreo rawmarshmallow's recipes,I want they can same with 1.8's version, sugarcube and trailmix's change I agree your mind,I will change it. And I will change it. I will finish it and merge it if you want continue the discussion, you can make a new issue or pull request.Finally,very thanks you like this mod and can do this.

skniro commented 1 year ago

I will change sugarcube need sugar size is 2,only 1 sugar i worry will break compatibility.