skoczen / will

Will is a simple, beautiful-to-code bot for slack, hipchat, and a whole lot more.
https://heywill.io
MIT License
406 stars 171 forks source link

Deprecate Python 2.7 #417

Open Ashex opened 4 years ago

Ashex commented 4 years ago

Python 2.7 EOL is fast approaching and which is leading to some fun things like pytest dropping support leading to our travis job failing.

Things to address including the following:

pastorhudson commented 4 years ago

I’m in favor of dropping legacy python 2.7. It’s only going to get worse as more packages drop support and people embrace f strings and walrus operators.

Ashex commented 4 years ago

The arguments against deprecation in #395 were heavily focused on supporting legacy environments or systems that couldn't run 3.x so I'd suggest that we have two releases, one being the last release with "official" 2.7 support and the following completely dropping it.

I'd consider that former release to be after we get some pending PRs merged then we can work on cleaning things up for the latter.

This would allow us to point users to a specific release if they desperately need to stay on 2.7.

pastorhudson commented 4 years ago

@Ashex I'm in favor of that path. I know @skoczen really wanted to keep 2.7 support, but I know I'm not likely to contribute PR's from my branch if I have to make sure it works in 2.7. I've already dropped 2.7 from my CI.

Since @skoczen said he would need a really compelling reason, here's my thoughts.

I prefer to stay here, but another option if the community here strongly opposes dropping 2.7 is to fork and have a "will3" repo or branch. Then new features could be borrowed and adapted with the owness on those needing legacy support to make it work on legacy python.

It's hard to convey tone in text. I really appreciate @skoczen and everybody here. This project captured my interest and has played a big role in my development with python. No hard feelings either way

edit: added info about Redhat and Mac edit2: Added 2018 Python Developer Survey edit3: Added 2019 Python Developer Survey (Just going for "compelling reasons")

BrianGallew commented 4 years ago

I'm going to put in my unasked-for $0.02: any organization with compliance requirements is going to be unable to continue using Will once Python-2.7 is officially deprecated ... so, now. I'm searching through the fork network today looking for functional Python3 builds because of this very reason.

Also? The Python2 -> 3 migration has been underway for years at this point.

Ashex commented 3 years ago

In case you have not seen recent activity, I'll be cutting a new release 2.2.0 that will drop support for python 2.7. Once I've submitted a PR to resolve #441 I will close this issue out as that's the only remaining item to cover environments being migrated.

pastorhudson commented 3 years ago

@Ashex thank you for all your work on this! Will Lives!