skodaconnect / homeassistant-myskoda

Homeassistant integration for MySkoda.
89 stars 15 forks source link

Added auxiliary heater climate entity #311

Closed prvakt closed 1 week ago

prvakt commented 1 week ago

Auxiliary heater added as separate climate entity. When started, and AC already running, AC must be switched off first. The same is valid for AC - when started and Auxiliary heater already running, auxiliary heater must be switched off first. If not, car will not change heater source

prvakt commented 1 week ago

Thanks for your contribution! 🥳

Can you see if you can solve the dependencies in the PR description for the user? For instance by making the aux heater unavailable if the ac is running, etc?

The power of HA is in doing the hard stuff right by default, we should try to keep up that approach :)

sorry I guess I didn't write it clearly - this is already solved - when user starts the Auxiliary heating and AC is running, AC is stopped.. same is valid for the opposite scenario -> I think this is better than making it unavailable

WebSpider commented 1 week ago

Thanks for your contribution! 🥳 Can you see if you can solve the dependencies in the PR description for the user? For instance by making the aux heater unavailable if the ac is running, etc? The power of HA is in doing the hard stuff right by default, we should try to keep up that approach :)

sorry I guess I didn't write it clearly - this is already solved - when user starts the Auxiliary heating and AC is running, AC is stopped.. same is valid for the opposite scenario -> I think this is better than making it unavailable

Indeed, I missed that in the initial review, thanks for already doing that!

If we can be a bit more verbose to the user, so they can see what's going on, that would be even awesomer! :clinking_glasses:

Tomanic-glitch commented 1 week ago

I have updated to v1.10.0 but don't see any new entity for the Auxiliary heater even if my Skoda Kodiaq is equipped with it and it's present in the Myskoda app as well as in the old Skoda Connect integration

myskoda skoda-connect version1 10 0

WebSpider commented 1 week ago

Thanks for your report, ive created a new issue to address this